Executor splited config Request

General Discussions
1 
version: '2.2'
services:
  agola-exec:
    image: registry.cn-shenzhen.aliyuncs.com/k-bin/sync-kube:t-agolademo
    command: serve --components executor
    tmpfs:
    - /run
    privileged: true
    network_mode: "host"
    environment:
    - VER=v1
    volumes:
    - ./vol-exec/agola:/data/agola
    - ./config-exec.yml:/config.yml
    - /var/run/docker.sock:/var/run/docker.sock

When I run executor in splited node, Just found that all other config needed to keep agola to run. except the flollowing, this may cause duplicate conf and may be secure problem with whole config in each node.

##4001
executor:
  dataDir: /data/agola/executor
  # The directory containing the toolbox compiled for the various supported architectures
  toolboxPath: ./bin
  runserviceURL: "http://xxx:4000"
  web:
    listenAddress: ":4001"
  activeTasksLimit: 2
  driver:
    type: docker
2

@huapox We could just improve config parsing to skip parsing of components definitions that aren’t enabled (agola --components options) so it won’t error if the config part of disabled components isn’t defined.

1 Like
3

Great!~~~~~~~~~~~~~~~~~~~~~~~

4

Created issue

5

Implemented in

1 Like